Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update conditions for is_incremental() to evaluate to true based on Issue 5279
What are you changing in this pull request and why?
This update is to address Issue 5279 - Understand the is_incremental() macro
I believe the original intent of the first two conditions was to say: "the model has to exist as a table" however saying this using two lines feels redundant and I know from training sessions that users react much the same way as the author of this issue.
I'm proposing the following wording:
Revised
The
is_incremental()
macro powers incremental materializations. It will returnTrue
if all of the following conditions are met:full-refresh
flag is not passedmaterialized='incremental'
Original (for reference)
The
is_incremental()
macro powers incremental materializations. It will returnTrue
if all of the following conditions are met:full-refresh
flag is not passedmaterialized='incremental'
Checklist
🚀 Deployment available! Here are the direct links to the updated files: